Chain adapters BIP44Params

[0xdef1cafe]

Overview

Any function/interface of chain-adapters that either hardcodes accountNumber to 0 or has bip44Params as an optional parameter must have it as a required parameter, and derive the accountNumber dynamically from the passed in bip44Params argument

References and additional details

• https://github.com/shapeshift/lib/blob/main/packages/chain-adapters/src/types.ts#L84 all references to bip44Params?: here must not be optional
• it is essential to approach this incrementally in separate PRs. it's almost certainly easier to start with certain functions that are less "core" so to speak, use your discretion/back out of an approach if it gets out of control quickly.

Acceptance Criteria

• Anywhere bip44Params is required it is not optional
• There is no accountNumber hardcoded to 0 in chain-adapters
• There is an accompanying PR in web for every PR in this repo as making bip44Params required anywhere in lib will be a breaking change in web

Need By Date

No response

Screenshots/Mockups

No response

Estimated effort

1 week

[0xdef1cafe]

closed by #1057