Giters

shapeshift / hdwallet

A library for interacting with hardware wallets from JS/TS.

Home Page:https://hdwallet.shapeshift.now.sh/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

`hdwallet-keepkey`'s `responseTypeRegistry` is outdated, broken, and unused

mrnerdhair opened this issue · comments

commented

packages/hdwallet-keepkey/src/responseTypeRegistry.ts is busted:

  • it's missing many new messages (e.g. cosmos, thorchain, etc) that have been added to the KK firmware
  • it contains an import type override for @keepkey/device-protocol (labelled as // Conflict between typedef and actual js export) which doesn't apply anymore, and actively breaks if the import is ever processed because there's not .default object exported
    • The broken import is optimized out in the built package, but fixing #470 by bumping parcel to v2 causes it to be processed and break
  • nothing in the whole file is used anywhere else, except for a single line in packages/hdwallet-keepkey/src/transport.ts that looks complicated but actually does nothing

AC:

  • Remove packages/hdwallet-keepkey/src/responseTypeRegistry.ts.