Giters

shapeshift / hdwallet

A library for interacting with hardware wallets from JS/TS.

Home Page:https://hdwallet.shapeshift.now.sh/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

`.gitignore` should be a whitelist

mrnerdhair opened this issue · comments

commented

Overview

.gitignore is currently allow-by-default, which inevitably leads to it being cluttered and difficult to maintain. Having a deny-by-default .gitignore would be preferable.

Reference

A deny-by-default .gitignore looks something like this.

Acceptance Criteria

  • Replace the .gitignore file with a deny-by-default version.
  • The new .gitignore file should not ignore any files not currently ignored.
  • The new .gitignore file should ignore at least all the files ignored by the current .gitignore which are present after a fresh git clone followed by yarn install, yarn build, yarn test, and yarn test:integration.

Ownership

  • As the sponsor of this bounty I will review the changes in a preview environment (ops/product) or review the PR (engineering)

Bounty Hunters

  • Join our Discord
  • Include an expected timeline for you to complete work in the work plan when you apply for this bounty!
  • Please refer to this link for some basic info
commented

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

This issue now has a funding of 500.0101 FOX (136.54 USD @ $0.27/FOX) attached to it.

commented

@thengoster - I have created a bounty for you! please apply on gitcoin.

commented

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

Workers have applied to start work.

These users each claimed they can complete the work by 264 years, 7 months from now.
Please review their action plans below:

1) sdmg15 has applied to start work (Funders only: approve worker | reject worker).

I've read the instructions and I'll add the deny-by-default .gitignore required
2) lolboysg has applied to start work (Funders only: approve worker | reject worker).

I've already worked with the codebase so I am going to change the .gitignore for a deny by default one
3) eunoia1729 has applied to start work (Funders only: approve worker | reject worker).

I'd like to work on this !
I've worked on opensource projects previously. I'll get this done within 5 days from today.
4) dm78985 has applied to start work (Funders only: approve worker | reject worker).

  • convert gitignore to deny by default
  • ensure that currently unignored files are not ignored in the new gitignore

Learn more on the Gitcoin Issue Details page.

commented

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

Work for 500.0101 FOX (156.18 USD @ $0.31/FOX) has been submitted by:

  1. @thengoster

@0xean please take a look at the submitted work:

commented

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

The funding of 500.0101 FOX (153.39 USD @ $0.31/FOX) attached to this issue has been approved & issued to @thengoster.