Latest commit breaks building without flags

Question

Latest commit breaks building without flags

Zegnat opened this issue 5 years ago · comments

Martijn van der Ven commented 5 years ago

The latest changes in 453548f add double quotes around build flags. This will break Zola when no build flags are defined:

$ zola build ""
error: Found argument '' which wasn't expected, or isn't valid in this context

As the default instructions for running this action pin it to the latest commit in the master branch, this temporarily broke my deployment. (I pinned it to the previous commit now instead.)

Folyd · Answer 1 · Tue Dec 03 2019 14:38:27 GMT+0800 (China Standard Time)

Same problem.

Shaleen Jain · Answer 2 · Tue Dec 03 2019 16:46:58 GMT+0800 (China Standard Time)

I see, sorry about that. But yes generally you should not be using the latest commit of the action. I have tagged releases with every new release of zola.
Maybe I'll try and do development on a different branch and then push to master when everything is stable.

Folyd · Answer 3 · Tue Dec 03 2019 16:59:32 GMT+0800 (China Standard Time)

Well, it seems like the latest release v0.9.0 isn't including the BUILD_DIR env option?

Martijn van der Ven · Answer 4 · Wed Dec 04 2019 00:00:13 GMT+0800 (China Standard Time)

But yes generally you should not be using the latest commit of the action. I have tagged releases with every new release of zola.

Yeah, I think I originally went off of your README, which pins to using the latest master. Obviously my mistake. Though an easy one to make for people copy pasting.

I also understand the reason for following Zola’s release versioning with your tagged releases, but as @Folyd points out, this means people cannot make use of new features added to the action until a new Zola release is made. That doesn’t really have a clear-cut solution, of course.