shadow / shadow-plugin-tor

A Shadow plug-in that runs the Tor anonymity software

Home Page:https://shadow.github.io

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Minimum number of probes?

ccheng32 opened this issue · comments

Context: I was trying to figure out how to shorten the period for probing all relays. Looked into the logs and realized that the relays that have already been measured keeps getting picked again.

if(*minProbes < probes) {

Looks like this logic here doesn't actually get the minimum number of probes among all relays in a slice. @robgjansen can you verify the behavior of this function?

Thanks!

Hmmm... this does appear to be a bug, because the _torflowslice_computeMinProbes function is actually computing the maximum number of probes instead of the minimum.

@ccheng32 could you please test 65778ef (linked above) and let me know if that fixes the problem you are seeing?