shadow / shadow-plugin-bitcoin

A Shadow plug-in that runs the Bitcoin Satoshi reference software

Home Page:https://shadow.github.io

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Building with Bitcoin 0.12.1 fails

smouldering opened this issue · comments

In the shadow-plugin-bitcoin directory after using the command make -j1 I get an error stating:-

make[2]: *** No rule to make target ../bitcoin/src/verison.cpp', needed by src/version.cpp.bc'. Stop.

Maybe this verison.cpp doesn't exist in Bitcoin 0.9.2 netmine edition and needs to be added to some cmake config file?

Seems version.cpp doesn't exist in later versions. Any pointers to what would need to be modified in the builder I'd be grateful.

If you just want to remove that file from the build, you could comment out this line:
https://github.com/shadow/shadow-plugin-bitcoin/blob/master/src/CMakeLists.txt#L143

I have no idea if that will cause other problems though.

Ah I see. Looking at the code I might have to add a lot of sources too, ill comment back on my findings.

It may be easier to grab all sources in the source directories, and then remove the ones you don't want. We do that for the Tor plugin:
https://github.com/shadow/shadow-plugin-tor/blob/master/src/tor/CMakeLists.txt#L136

Yeah that does sound easier, my assumption is to write aux_source_directory(${BITCOIN_ROOT_DIR}/src bitcoin_sources). I'll give that a try.

EDIT: Just seen it's already in there just commented out: https://github.com/shadow/shadow-plugin-bitcoin/blob/master/src/CMakeLists.txt#L93

It does pick up the sources and starts to build them but, it cannot build key.cpp as 'secp256k1.h' doesn't exist. So, like the Bitcoin make file, the dependencies need building first and somehow linked to building the rest of the Bitcoin source.

EDIT: My guess is each new source folder will be added tt the CMakeLists.txt file in the same way leveldb was originally.