sgnl / nodeku

discover and control Roku devices with NodeJS

Home Page:https://medium.com/@sgnl/nodeku-control-your-roku-with-node-js-d8b8c87cdba6

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Tests aren't being run

bschlenk opened this issue · comments

I wrote a test for a pull request and realized it should have been failing, but it wasn't. The wrapper code that everything uses never actually runs the tests :P

This:

function wrapper(description) {
  test(description, async t => {
    const device = await Nodeku();
    t.truthy(device);
  });
}

should be this:

function wrapper(description, func) {
  test(description, async t => {
    const device = await Nodeku();
    t.truthy(device);
    func(t, device);
  });
}

I would send a pull request, but updating it causes a few of the existing tests to fail.

I'll have time to update this on the weekend. Thanks for reporting