sgnl / nodeku

discover and control Roku devices with NodeJS

Home Page:https://medium.com/@sgnl/nodeku-control-your-roku-with-node-js-d8b8c87cdba6

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Why immutable.js?

bschlenk opened this issue · comments

I don't really see the point in making the responses immutable. There is no performance gain to be had by doing this, and it makes dealing with the lists and maps a bit quirky as they don't behave like standard js objects. Anybody using this api should already know that the responses are readonly.

Yeah I feel the same. I just did it just because. I'd remove it the next chance I get.

@sgnl is Immutable.js something you would like removed? If so, would you be interested in receiving a Pull Request or have you already started this work?

@Glavin001 New version has landed on NPM

removed Immutable
the fix we talked about earlier should be there now (I forgot to bump the version so it may have not landed on NPM like I thought it did previously)

🍰