Twitter::Client#blank? conflicts with rails #blank? and #present?

Question

Twitter::Client#blank? conflicts with rails #blank? and #present?

matteeyah opened this issue 5 years ago · comments

Matija Čupić commented 5 years ago

Twitter::Client#blank? conflicts with the usage of rails #blank? and #present?.

It should be renamed to something else that's ambiguous and not used in rails.

Erik Berlin · Answer 1 · Thu Feb 13 2020 01:46:00 GMT+0800 (China Standard Time)

What’s the actual issue here? This is a private method, so it shouldn’t conflict.

Matija Čupić · Answer 2 · Thu Feb 13 2020 05:23:17 GMT+0800 (China Standard Time)

I wish I explained this better at the time of opening. I can't seem to remember what it conflicted with exactly, but I'm 100% positive that it somehow had a negative impact to the usability of this gem (otherwise I wouldn't have opened it).