seydx / camera.ui

NVR like user Interface for RTSP capable cameras

Home Page:https://github.com/seydx/camera.ui

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Cannot read properties of undefined (reading 'toFixed')

captainerd opened this issue · comments

Describe the bug
At starting the server and/or at radom times (not sure for the last one) we may get TypeError: Cannot read properties of undefined (reading 'toFixed')

To Reproduce
Enable recording start the server.

Expected behavior
Record

Logs

Screenshots

Environment

  • Node.js Version: v16.15.0
  • Camera UI Version: v17
  • Operating System: win10
  • Browser: XXX

Seems it is caused by this piece of (Orphan?) code at the event.cotroller.js

      if (!allowRecording) {
            log.warn(
              `The available disk space is less than 1 GB (${diskSpace.available.toFixed(2)
              } GB)! Please free up disk space to be able to create new recordings!`,
              cameraName
            );

            log.info('Skip local storage of the recording..', cameraName);
          }

PS. despite allowRecording would be true which ! will equal not true. expecting someone when recording is true this will be ignored. (i guess as far as i can see) seems removing this completly solved also the issue.