seungeunrho / minimalRL

Implementations of basic RL algorithms with minimal lines of codes! (pytorch based)

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

train() overwrites the base method of nn.Module

NikEyX opened this issue · comments

You may want to rename it, since .train() and .eval() are important methods of the base class, and new people might be picking up a wrong habit here. Just a thought.

I think that is very good advice.
I've never thought about it. I should rename them.
I will update the code soon. Thank you.