Import path seems to be ambiguous

Question

mwf opened this issue 4 years ago · comments

Hi!

import "github.com/sethvargo/go-envconfig/pkg/envconfig"

Such import contains almost duplicated parts - go-envconfig and envconfig at the end.
Have you thought about moving go code to the project root?

We will have more elegant and meaningful import path then.

Done

Seth Vargo · Answer 1 · Mon Jun 29 2020 22:52:04 GMT+0800 (China Standard Time)

Some folks brought this up on Twitter. I'm happy to move it, but I think that will break existing imports.

Mike Helmick · Answer 2 · Tue Jun 30 2020 00:30:36 GMT+0800 (China Standard Time)

I think it's fine to do as long we assign a long lived version to the way it currently is (0.1?)

Ivan Korolev · Answer 3 · Sat Jul 04 2020 05:30:48 GMT+0800 (China Standard Time)

Thanks!

It's great you decided to fix the import path :)
0.1 version is indeed young enough for such changes.

github-actions · Answer 4 · Sat Jul 18 2020 08:10:14 GMT+0800 (China Standard Time)

This issue has been automatically locked since there has not been any
recent activity after it was closed. Please open a new issue for
related bugs.