Unit tests fail on Windows because of path separator

Question

Unit tests fail on Windows because of path separator

HyperBrain opened this issue 7 years ago · comments

This is a Bug Report

Description

When running npm test on Windows, the unit tests fail like:

      + expected - actual

       {
         "filename": "last"
         "libraryTarget": "commonjs"
      -  "path": "testpath\\.webpack"
      +  "path": "testpath/.webpack"
       }

The failures happen in multiple tests, everywhere where paths are checked against
their expectations.

Proposed solution

The expectations should be composed by using path.sep as path separator to keep the tests platform independent.

Frank Schmid commented 7 years ago

V3 merged

Hassan Khan · Answer 1 · Tue Jul 04 2017 22:27:47 GMT+0800 (China Standard Time)

Perhaps we could use AppVeyor to run the tests on a Windows-based CI in the future?

Frank Schmid · Answer 2 · Tue Jul 04 2017 22:35:02 GMT+0800 (China Standard Time)

Sounds like a good idea. This would complement Travis (where we can run linux and osx tests) perfectly. I will take care of the Travis integration in the next days, and will do some experiments with AppVeyor too.

Frank Schmid · Answer 3 · Fri Jul 14 2017 18:42:34 GMT+0800 (China Standard Time)

The issue on Windows is not just replacing the path separators. After fixing these, the unit tests on Windows still bail out with a failing require that seems to behave differently on Windows and Linux. Did the same test on Linux and it worked.
Will continue with this.

Frank Schmid · Answer 4 · Tue Aug 01 2017 04:37:17 GMT+0800 (China Standard Time)

Will suspend work on this, until the code base for 3.0.0 is ready. Due to the removal of serve and run, the unit tests should be runnable on Windows again with only a few changes.