serilog / serilog-extensions-logging

Serilog provider for Microsoft.Extensions.Logging

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

`LoggerProviderCollection` should not be `IDisposable`

nblumhardt opened this issue · comments

The providers within it are generally owned by the composition system, e.g. https://github.com/serilog/serilog-extensions-logging/blob/dev/samples/Sample/Program.cs#L31 - so it has no business disposing them :-)

Second thoughts, this needs a careful look, providers may not be flushed if they're not otherwise disposed by the DI container.

given v3 has been released. is this included in that milestone? and should the milestone be closed

Thanks 👍