serilog / serilog-extensions-logging-file

Add file logging to ASP.NET Core apps in one line of code.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Can't set shared property for rollingfile settings

KyberMage opened this issue · comments

We seem to be able to configure all rollingfile settings except for file sharing. The code for some reason has a preprocessor directive to set it to true or false if SHARED is defined, but it is not and there is no way to set that via code (obviously). We should be able to set this property.

Thanks for the note. Sharing wasn't originally supported for .NET Core, hence the #if. It has been for a while though, so I've just PR'd a change to enable it on all platforms.

Are you able to check out package version 1.1.0-dev-00014 to make sure this works as expected for your target? Should be a safe/low-impact change to push through to master.

@nblumhardt Looks to be working fine.

commented

Not working in 3.3.0 version.