Explicit = Operator for elfio Segfault

Question

Explicit = Operator for elfio Segfault

foreverska opened this issue 3 years ago · comments

Correct me if I'm wrong but ELFIO::elfio seems to have an explicit = operator which does a shallow copy of pointers within the object. This causes a segfault on second deconstruction if you happen to use it.

It should probably be explicitly deleted, a deep copy implemented or a solution which can survive a shallow copy (thread safety + shared pointers).

Serge Lamikhov-Center · Answer 1 · Tue Mar 30 2021 02:24:09 GMT+0800 (China Standard Time)

Thank you for mentioning this. Indeed, the copy constructor and assignment operator are not supported.
I have added their deletion in commit 29114f6.

Please let me know your results.

Pavel I. Kryukov · Answer 2 · Tue Mar 30 2021 02:34:21 GMT+0800 (China Standard Time)

I propose following Rule of Five to the end and define move ctor and assignment operator, at least with = default; syntax.

Serge Lamikhov-Center · Answer 3 · Tue Mar 30 2021 06:01:42 GMT+0800 (China Standard Time)

Hi @pavelkryukov, thank you for the advice. The move constructor and assignment are implemented in f591a3b.
Just to make sure - is this what you meant?

Pavel I. Kryukov · Answer 4 · Tue Mar 30 2021 15:10:26 GMT+0800 (China Standard Time)

Yes, looks great.

Serge Lamikhov-Center · Answer 5 · Wed Mar 31 2021 05:05:35 GMT+0800 (China Standard Time)

Please reopen if you feel that the issue still persists