Giters

sensu-plugins / sensu-plugins-aws

This plugin provides native AWS instrumentation for monitoring and metrics collection, including: health and metrics for various AWS services, such as EC2, RDS, ELB, and more, as well as handlers for EC2, SES, and SNS.

Home Page:http://sensu-plugins.io

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Create major (breaking) release without aws sdk v1

runningman84 opened this issue · comments

commented

It is not possible to install the aws plugins with the latest sensu releases:

`Unable to activate aws-sdk-v1-1.66.0, because json-2.1.0 conflicts with json (~> 1.4)` `json (2.1.0, default: 2.0.2, 1.8.6)`

In order to fix this I would propose the release of a new major release without any v1 checks.

commented

@runningman84 thanks for raising the issue, I think we need to first take a look at the impact on the number of checks and either need to make a decision to remove or update them. ping @eheydrick

commented

Of the 76 checks, 11 are still using aws-sdk v1. I think we should put in the effort to update them to v2.

  • check-elb-certs.rb
  • check-elb-health-sdk.rb
  • check-elb-latency.rb
  • check-elb-nodes.rb
  • check-elb-sum-requests.rb
  • check-redshift-events.rb
  • handler-ses.rb
  • handler-sns.rb
  • metrics-ec2-count.rb
  • metrics-elb-full.rb
  • metrics-sqs.rb

EDIT: made it a checklist by @majormoses

commented

5 checks have been updated to AWS-SDK v2 and released in 9.0.0. 6 left to update.
https://rubygems.org/gems/sensu-plugins-aws/versions/9.0.0.

commented

I will try to take these ones this weekend:

  • check-elb-latency.rb
  • check-elb-sum-requests.rb
commented

I added the handlers as they also required v1

commented

I have handler-ses almost ready to PR. Going to do handler-sns after that.

commented

Handlers have been updated for AWS-SDK v2 and released in 10.0.0. Going to update the remaining 4 checks next. https://rubygems.org/gems/sensu-plugins-aws/versions/10.0.0

commented

Sorry I have been super busy if I have some time I will get to it but if someone has the time feel free to jump in.

commented

I have check-elb-latency just about ready to PR.

commented

As a side note, check-elb-health-fog.rb and check-elb-health.rb are the only plugins not using the AWS SDK (nor v1 nor v2), but as explained in #254 (comment) I think they could be removed in favor of check-elb-health-sdk.rb which should do the same job as the two others.

commented

@multani thanks for helping out with this!

commented

All the assets have been updated, Great work and Thanks to everyone who pitched in.

commented

Glad to see this come together. Thanks everyone!