Adding array reduce functionality

Question

Adding array reduce functionality

Fatxx opened this issue 7 years ago · comments

André Fatia commented 7 years ago

hello @selfrefactor ,

Are you willing to accept an implementation for R.reduce()? Or is it out of scope?

Thank you and keep the good work.

Dejan Toteff · Answer 1 · Wed Jun 28 2017 14:40:03 GMT+0800 (China Standard Time)

Will be implemented before the end of the week.
Thank you for the good words.

André Fatia · Answer 2 · Wed Jun 28 2017 18:47:54 GMT+0800 (China Standard Time)

Can I open a merge request with this?

Dejan Toteff · Answer 3 · Wed Jun 28 2017 19:46:35 GMT+0800 (China Standard Time)

Sure, you can 👍

Dejan Toteff · Answer 4 · Wed Jun 28 2017 19:56:46 GMT+0800 (China Standard Time)

I check your PR, there are some things to be done, before proceeding to build process and npm publish

My edit will curry initialValue as now it is not handled. After doing this and write a few more test cases, we are ready to proceed further. I am at work now, so I will do that later today.

André Fatia · Answer 5 · Wed Jun 28 2017 20:00:56 GMT+0800 (China Standard Time)

Ok, great! Thank you.

Dejan Toteff · Answer 6 · Thu Jun 29 2017 00:02:06 GMT+0800 (China Standard Time)

Published to NPM and closing the issue.