sebnitu / vrembem

A CSS component library based on the BEM methodology.

Home Page:https://vrembem.com

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Maybe move global changes in modal sequence to its own process

sebnitu opened this issue · comments

Problem

Currently, we're setting inert and overflow styles in the modal module during the open and close sequence. With the upcoming feature of modal stacking, it's theoretically possible for the inert and overflow states to be incorrect depending on which open/close process finishes last. Should look into a solution for this such as maybe removing these actions from within the open/close methods and into their own processes that get triggered and analyzed after a modal state changes.

Fixed in #853