MyModel.delete() doesn't work with string ids

[Arina]

[Sébastien Loix]

Hi,

Thanks for reporting. This is strange, I will check if there were a regression. Cheers 👍

Should I move this issue to the gstore-node repository?

[Arina]

Okay

[Sébastien Loix]

Just to make sure, you are saying that it does not work with an Array of string ids, is that correct?

[Arina]

I'm pretty sure that it's both, single id and array

[Sébastien Loix]

Hello,
I finally got a chance to look at it. Indeed, MyModel.get() MyModel.update() and MyModel.delete() don't work with string id. You need to parse it to integer first

const id = '1234';
MyModel.delete(+id);

This is because Datastore treats a string as "name" in the entity key and not "id". I plan on updating the gstore API (next major version) for those methods where you would have to specify if you are providing a Key id or a Key name. Probably something like this:

const id = '1234';
MyModel.delete({ id });

const name = '[e-mail]';
MyModel.delete({ name });

Cheers 👍

[Sébastien Loix]

I will close this issue as it will be solved with this issue: #212