"declare", "namespace", and "use" are not handled correctly
JeroenDeDauw opened this issue · comments
"LLOC not in classes or functions" is including these things:
declare( strict_types = 1 );
- namespace declaration
- import statements
When phploc reported 2000+ LLOC under "not in classes or functions" I was somewhat WTF. Strictly speaking it is not wrong I suppose, though it is making the distinction in a way that I unsuspected to me, and makes the metric kinda useless.
👍 Yep, I just noticed the very same thing. Would be nice to get this fixed.
This issue has been automatically marked as stale because it has not had activity within the last 60 days. It will be closed after 7 days if no further activity occurs. Thank you for your contributions.
This issue has been automatically closed because it has not had activity since it was marked as stale. Thank you for your contributions.
I think this would still be a valuable feature to have. Without it, the "LLOC not in classes or functions" metric is useless to anyone with a modern PHP codebase.
I was also irritated by this. Could this issue be reopened please?
This issue has been automatically marked as stale because it has not had activity within the last 60 days. It will be closed after 7 days if no further activity occurs. Thank you for your contributions.
#activity
I would appreciate a pull request that fixes this a lot more than comments that prevent this ticket from going stale. I do not care enough about this to fix it myself, sorry.
Fair enough for not spending time on fixing this, though personally I find it odd that a ticket about a feature being broken gets closed just because there is little maintenance effort put into this tool.