"declare", "namespace", and "use" are not handled correctly

Question

"declare", "namespace", and "use" are not handled correctly

JeroenDeDauw opened this issue 8 years ago · comments

"LLOC not in classes or functions" is including these things:

declare( strict_types = 1 );
namespace declaration
import statements

When phploc reported 2000+ LLOC under "not in classes or functions" I was somewhat WTF. Strictly speaking it is not wrong I suppose, though it is making the distinction in a way that I unsuspected to me, and makes the metric kinda useless.

Jeroen De Dauw commented 5 years ago

#activity

Petr Kotek · Answer 1 · Fri Dec 09 2016 15:50:53 GMT+0800 (China Standard Time)

👍 Yep, I just noticed the very same thing. Would be nice to get this fixed.

stale · Answer 2 · Sun Jun 03 2018 10:18:12 GMT+0800 (China Standard Time)

This issue has been automatically marked as stale because it has not had activity within the last 60 days. It will be closed after 7 days if no further activity occurs. Thank you for your contributions.

stale · Answer 3 · Sun Jun 10 2018 10:53:51 GMT+0800 (China Standard Time)

This issue has been automatically closed because it has not had activity since it was marked as stale. Thank you for your contributions.

Jeroen De Dauw · Answer 4 · Sun Jun 10 2018 11:19:11 GMT+0800 (China Standard Time)

I think this would still be a valuable feature to have. Without it, the "LLOC not in classes or functions" metric is useless to anyone with a modern PHP codebase.

Tobias Schultze · Answer 5 · Thu Jan 10 2019 18:13:13 GMT+0800 (China Standard Time)

I was also irritated by this. Could this issue be reopened please?

Jeroen De Dauw · Answer 6 · Thu Jan 10 2019 18:52:49 GMT+0800 (China Standard Time)

@sebastianbergmann

stale · Answer 7 · Mon Mar 11 2019 20:35:47 GMT+0800 (China Standard Time)

This issue has been automatically marked as stale because it has not had activity within the last 60 days. It will be closed after 7 days if no further activity occurs. Thank you for your contributions.

Sebastian Bergmann · Answer 8 · Tue Mar 12 2019 00:06:00 GMT+0800 (China Standard Time)

I would appreciate a pull request that fixes this a lot more than comments that prevent this ticket from going stale. I do not care enough about this to fix it myself, sorry.

Jeroen De Dauw · Answer 9 · Tue Mar 12 2019 06:59:09 GMT+0800 (China Standard Time)

Fair enough for not spending time on fixing this, though personally I find it odd that a ticket about a feature being broken gets closed just because there is little maintenance effort put into this tool.