scylladb / scylladb

NoSQL data store using the seastar framework, compatible with Apache Cassandra

Home Page:http://scylladb.com

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

enable_compacting_data_for_streaming_and_repair has to be LiveUpdate

denesb opened this issue · comments

In theory it is, but when propagated down to the table object, the LiveUpdate property is lost (database.cc):

1251     cfg.enable_compacting_data_for_streaming_and_repair = db_config.enable_compacting_data_for_streaming_and_repair();

Here, we use named_value<T>::operator(), which casts the utils::updateable_value<T> to const T& and hence the update signal chain is broken. table::config::enable_compacting_data_for_streaming_and_repair is bound to a constant and will not receive updates on the config item.