scylladb / scylla-jmx

Scylla JMX proxy

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

offline install does't provide openjdk-8, it has to be installed in advance

amoskong opened this issue · comments

version: scylla-jmx master

Currently (unified-package) offline install does't provide openjdk-8, it has to be installed in advance.
It's a known issue, and it's low priority, but we don't have issue to track it.

The old offline installer (https://github.com/scylladb/scylla/wiki/Offline-Installer) depends on RPM/DEB, and openjdk dependency can be solved.

[scylla-test@amos-centos7-offline-installer scylla-jmx]$ ./install.sh --nonroot --prefix `pwd`/install_root
Please install openjdk-8 before running install.sh.
[scylla-test@amos-centos7-offline-installer scylla-jmx]$ echo $?
1

install the openjdk manually

# sudo yum install java-1.8.0-openjdk

Dependencies Resolved

===============================================================================================================================================================
 Package                                         Arch                       Version                                          Repository                   Size
===============================================================================================================================================================
Installing:
 java-1.8.0-openjdk                              x86_64                     1:1.8.0.262.b10-0.el7_8                          updates                     299 k
Installing for dependencies:
 atk                                             x86_64                     2.28.1-2.el7                                     base                        263 k
 avahi-libs                                      x86_64                     0.6.31-20.el7                                    base                         62 k
 cairo                                           x86_64                     1.15.12-4.el7                                    base                        741 k
 copy-jdk-configs                                noarch                     3.3-10.el7_5                                     base                         21 k
 cups-libs                                       x86_64                     1:1.6.3-43.el7                                   base                        358 k
 dejavu-fonts-common                             noarch                     2.33-6.el7                                       base                         64 k
 dejavu-sans-fonts                               noarch                     2.33-6.el7                                       base                        1.4 M
 fontconfig                                      x86_64                     2.13.0-4.3.el7                                   base                        254 k
 fontpackages-filesystem                         noarch                     1.44-8.el7                                       base                        9.9 k
 fribidi                                         x86_64                     1.0.2-1.el7_7.1                                  base                         79 k
 gdk-pixbuf2                                     x86_64                     2.36.12-3.el7                                    base                        570 k
 giflib                                          x86_64                     4.1.6-9.el7                                      base                         40 k
 graphite2                                       x86_64                     1.3.10-1.el7_3                                   base                        115 k
 gtk-update-icon-cache                           x86_64                     3.22.30-5.el7                                    base                         27 k
 gtk2                                            x86_64                     2.24.31-1.el7                                    base                        3.4 M
 harfbuzz                                        x86_64                     1.7.5-2.el7                                      base                        267 k
 hicolor-icon-theme                              noarch                     0.12-7.el7                                       base                         42 k
 jasper-libs                                     x86_64                     1.900.1-33.el7                                   base                        150 k
 java-1.8.0-openjdk-headless                     x86_64                     1:1.8.0.262.b10-0.el7_8                          updates                      33 M
 javapackages-tools                              noarch                     3.4.1-11.el7                                     base                         73 k
 jbigkit-libs                                    x86_64                     2.0-11.el7                                       base                         46 k
 libICE                                          x86_64                     1.0.9-9.el7                                      base                         66 k
 libSM                                           x86_64                     1.2.2-2.el7                                      base                         39 k
 libX11                                          x86_64                     1.6.7-2.el7                                      base                        607 k
 libX11-common                                   noarch                     1.6.7-2.el7                                      base                        164 k
 libXau                                          x86_64                     1.0.8-2.1.el7                                    base                         29 k
 libXcomposite                                   x86_64                     0.4.4-4.1.el7                                    base                         22 k
 libXcursor                                      x86_64                     1.1.15-1.el7                                     base                         30 k
 libXdamage                                      x86_64                     1.1.4-4.1.el7                                    base                         20 k
 libXext                                         x86_64                     1.3.3-3.el7                                      base                         39 k
 libXfixes                                       x86_64                     5.0.3-1.el7                                      base                         18 k
 libXft                                          x86_64                     2.3.2-2.el7                                      base                         58 k
 libXi                                           x86_64                     1.7.9-1.el7                                      base                         40 k
 libXinerama                                     x86_64                     1.1.3-2.1.el7                                    base                         14 k
 libXrandr                                       x86_64                     1.5.1-2.el7                                      base                         27 k
 libXrender                                      x86_64                     0.9.10-1.el7                                     base                         26 k
 libXtst                                         x86_64                     1.2.3-1.el7                                      base                         20 k
 libXxf86vm                                      x86_64                     1.1.4-1.el7                                      base                         18 k
 libfontenc                                      x86_64                     1.1.3-3.el7                                      base                         31 k
 libglvnd                                        x86_64                     1:1.0.1-0.8.git5baa1e5.el7                       base                         89 k
 libglvnd-egl                                    x86_64                     1:1.0.1-0.8.git5baa1e5.el7                       base                         44 k
 libglvnd-glx                                    x86_64                     1:1.0.1-0.8.git5baa1e5.el7                       base                        125 k
 libjpeg-turbo                                   x86_64                     1.2.90-8.el7                                     base                        135 k
 libthai                                         x86_64                     0.1.14-9.el7                                     base                        187 k
 libtiff                                         x86_64                     4.0.3-32.el7                                     base                        171 k
 libwayland-client                               x86_64                     1.15.0-1.el7                                     base                         33 k
 libwayland-server                               x86_64                     1.15.0-1.el7                                     base                         39 k
 libxcb                                          x86_64                     1.13-1.el7                                       base                        214 k
 libxshmfence                                    x86_64                     1.2-1.el7                                        base                        7.2 k
 libxslt                                         x86_64                     1.1.28-5.el7                                     base                        242 k
 lksctp-tools                                    x86_64                     1.0.17-2.el7                                     base                         88 k
 mesa-libEGL                                     x86_64                     18.3.4-7.el7_8.1                                 updates                     109 k
 mesa-libGL                                      x86_64                     18.3.4-7.el7_8.1                                 updates                     165 k
 mesa-libgbm                                     x86_64                     18.3.4-7.el7_8.1                                 updates                      39 k
 mesa-libglapi                                   x86_64                     18.3.4-7.el7_8.1                                 updates                      46 k
 pango                                           x86_64                     1.42.4-4.el7_7                                   base                        280 k
 pcsc-lite-libs                                  x86_64                     1.8.8-8.el7                                      base                         34 k
 pixman                                          x86_64                     0.34.0-1.el7                                     base                        248 k
 python-javapackages                             noarch                     3.4.1-11.el7                                     base                         31 k
 python-lxml                                     x86_64                     3.2.1-4.el7                                      base                        758 k
 ttmkfdir                                        x86_64                     3.0.9-42.el7                                     base                         48 k
 tzdata-java                                     noarch                     2020a-1.el7                                      updates                     188 k
 xorg-x11-font-utils                             x86_64                     1:7.5-21.el7                                     base                        104 k
 xorg-x11-fonts-Type1                            noarch                     7.5-9.el7                                        base                        521 k

Transaction Summary
===============================================================================================================================================================
Install  1 Package (+64 Dependent packages)

Total download size: 46 M
Installed size: 152 M

[scylla-test@amos-centos7-offline-installer scylla-jmx]$ java -version
openjdk version "1.8.0_262"
OpenJDK Runtime Environment (build 1.8.0_262-b10)
OpenJDK 64-Bit Server VM (build 25.262-b10, mixed mode)

/CC @roydahan @penberg @slivne

The user has to install the Java environment, we're not going to bundle it.

Java11 should be used not java8 - We need to understand why Java8 is still needed and not 11

On Thu, Aug 20, 2020 at 10:22 AM Avi Kivity @.***> wrote: The user has to install the Java environment, we're not going to bundle it. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#127 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA2OCCDEGFXDQPCF4SWXUILSBTFLRANCNFSM4QFR6YKA .

install.sh of scylla-jmx:

It only checked 1.8.0, and the error message should be fixed. 1.8, 1.11 should all work.

if ! $packaging; then
    has_java=false
    if [ -x /usr/bin/java ]; then
        javaver=$(/usr/bin/java -version 2>&1|head -n1|cut -f 3 -d " ")
        if [[ "$javaver" =~ ^\"1.8.0 ]]; then
            has_java=true
        fi
    fi
    if ! $has_java; then
        echo "Please install openjdk-8 before running install.sh."
        exit 1
    fi
fi

openjdk11 is only available on new ubuntu distros.

For centos (7 &8), we only require java 1.8.

For ubuntu/deb: we try to find 1.8 / 1.11. If 1.8 and 1.11 all exist, 1.8 will be used. not 1.11.
Is it a problem? or expected.

dist/debian/control.template:Depends: ${shlibs:Depends}, ${misc:Depends}, openjdk-8-jre-headless | openjdk-8-jre | oracle-java8-set-default | adoptopenjdk-8-hotspot-jre, %{product}-server
dist/debian/control.template:Conflicts: openjdk-11-jre-headless, openjdk-11-jre, oracle-java11-set-default

@amoskong Our JMX and tools should run on both Java 8 and Java 11. Are you seeing some problem with either of them? If so, please report, and let's get it fixed.

@penberg Could it be related to scylladb/scylladb#6303 ?

@amoskong Our JMX and tools should run on both Java 8 and Java 11. Are you seeing some problem with either of them? If so, please report, and let's get it fixed.

Both versions work well. I'm asking if current order / priority is fine, Java 8 will be installed even Java 11 is also available from the apt repo. Is it expected?

The offline installer doesn't install java, does it? I'm confused.

@avikivity I think the issue is that even if you install Java before, it will not be able to install scylla-jmx and tools unless you installed java-8 !!! in debian10 for example the official Java version is 11. I think it's related to this commit scylladb/scylladb@e664289

Oh, then we should drop the Conflicts tag.

according to @penberg

we run with java11 fine and the user should install java8 or java11 on his own

install.sh of scylla-jmx:

It only checked 1.8.0, and the error message should be fixed. 1.8, 1.11 should all work.

I will open a new issue for this issue.

  • "Please install openjdk-8 or openjdk-11 before running install.sh."
if ! $packaging; then
    has_java=false
    if [ -x /usr/bin/java ]; then
        javaver=$(/usr/bin/java -version 2>&1|head -n1|cut -f 3 -d " ")
        if [[ "$javaver" =~ ^\"1.8.0 ]]; then
            has_java=true
        fi
    fi
    if ! $has_java; then
        echo "Please install openjdk-8 before running install.sh."
        exit 1
    fi
fi