scup / atellier

The smartest way to share interactive components with your team.

Home Page:http://scup.github.io/atellier/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Package should not be published with React bundled to avoid errors relative to multiple versions of React being present in the final bundle

PCreations opened this issue · comments

In the webpack config, the following option should be added to avoid bundling react with this package :
externals: { 'react': 'react', 'react-dom': 'react-dom' },
This fixes the issue relative to multiple version of React such as 'Only a ReactOwner can have refs' (see #32)

The issue with 'Only a ReactOwner can have refs' is because of multiple packages of React.
Bundle dist/react-atellier.js should be bundled without React inside.

As temporary solution (if you use webpack in your project), you can copy source files and webpack configs from atellier and import directly in your project.

More description about this issue found here

@PCreations Can we close this issue?

If it has been fixed, yes, sure :)

@PCreations please check if it has been fixed for you.