console.log('test) left in code

Question

console.log('test) left in code

Ddk34 opened this issue 6 years ago · comments

Ddk34 commented 6 years ago

Hi, theres a console.log('test) in the alignNearestInline function.

Cody Olsen · Answer 1 · Tue May 22 2018 22:19:41 GMT+0800 (China Standard Time)

Yikes! Thanks for reporting! I'm gonna add an linter rule to prevent it from sneaking in again 😄

Cody Olsen · Answer 2 · Tue May 22 2018 22:35:44 GMT+0800 (China Standard Time)

wait, I can't find it. What version is this?

Cody Olsen · Answer 3 · Thu May 24 2018 05:45:08 GMT+0800 (China Standard Time)

This error were in a pre-release of v2: https://github.com/stipsan/scroll-into-view-if-needed/blob/ec038fe211a25aaee0e9433bbd12b1ed94cc02ed/packages/scroll-into-view-if-needed/src/compute.ts#L149-L162

The functions alignNearestInline and alignNearestBlock was combined into a shared alignNearest function in the 2.1.1 prerelease 5068ad9#diff-9a0f3e8246354a0d47a96969f9b23aaa

The weird prerelease naming scheme was because of a limitation in the semantic release setup. The first stable v2 release is https://github.com/stipsan/scroll-into-view-if-needed/releases/tag/v2.1.3

I recommend you use the latest stable release as it not only don't have a console.log('test') calls, but don't suffer from problems with border widths or problems with block: 'nearest'.

I've added some protection on the CI though so it's not possible to leave console calls in the codebase by accident anymore: #252