I always receive 2 calls when invoke to the method requestTest

Question

I always receive 2 calls when invoke to the method requestTest

moisesvs opened this issue 8 years ago · comments

Hi!

Now when I invoke to method requestTest I always receive 2 calls onSuccess. I was reviewing the code and I found that first the library sends a callback success and after passes the call to AndroidDeviceVerifier and the AndroidDeviceVerifier returns another success response. In total 2 calls to methods success.

But I only need one call to method success. Why do the library send me 2 calls on success? Will have something fix?

Andrey Tumanov · Answer 1 · Mon Jun 06 2016 17:18:07 GMT+0800 (China Standard Time)

https://github.com/scottyab/safetynethelper/blob/master/safetynetlib/src/main/java/com/scottyab/safetynet/SafetyNetHelper.java#L157

This statement should be in else block.

Moisés · Answer 2 · Tue Jun 07 2016 17:43:53 GMT+0800 (China Standard Time)

When could you upload new version of library with this fix?

Scott Alexander-Bown · Answer 3 · Tue Jun 07 2016 17:47:42 GMT+0800 (China Standard Time)

Thanks for reporting this @moisesvs feel free to put in pull request and I'll review that and the 2 pending PR's and then all being well publish into next version of the lib.

Scott Alexander-Bown · Answer 4 · Thu Jun 09 2016 16:45:20 GMT+0800 (China Standard Time)

in progress

Scott Alexander-Bown · Answer 5 · Thu Jun 09 2016 17:56:18 GMT+0800 (China Standard Time)

@moisesvs Fixed in v0.2.0 Thanks again for reporting