favicon.get function call is stuck for following urls
lab-rk opened this issue · comments
the function call is running endlessly and stuck for the following urls
- https://www.tatacliq.com/lenovo-ideapad-330s-81f401jhin-i3-7th-gen4gb1tb355614windows-10int-platinum-grey/p-mp000000004820347?&cid=ps:Tata_CLiQ_Interim_Ssc_Non_Hitlist:Google:Non_Hitlist:PLA_Electronics&gclid=Cj0KCQjw6cHoBRDdARIsADiTTzYw13BB6WjxSLb83m4lsszY0k_9K_iQ7sH3ScTe9pOXlPbDQpPR_Y4aAromEALw_wcB&gclsrc=aw.ds
- https://www.tatacliq.com/
You can add https://www.khou.com to that list.
when issuse favicon.get(' https://www.khou.com') program never responds back. Gone to never never land.
I had originally written my own method to fetch a website's favicon, and it worked nicely. But it was very complicated because it checked a layer of possibilities since websites can have their favicon configured numerous ways.
The downside is that it took about 1 second per request, and when you have a page with 8-10, it takes a few seconds to boot up the server while it caches the calls.
So I figured I'd try this library out to see if it was faster, and I'm noticing this hanging issue as well, and I've tried several ways to try and abort the connection, including a timeout / user agent.
Has anyone found a solution around this? I may just go back to my script because I'm not seeing a huge benefit, and mine didn't cease up, timeouts worked great.