simplyfoc library issue
wangxinghe88 opened this issue · comments
Askuric's simplyfoc project has been updated to 2.3.1 and there is changes in function's parameteres, which will generate error in the code.
solution：
In the platfromio.ini file, lib_deps should be changed to:
askuric/Simple FOC@2.3.0
I think the typo "@^2.3.0" makes the version up to V2.3.1 unintentedly.
I think the issue is in Askuric's simplyfoc ... if a breaking changes is introduced (like a change in function's parameters) then he should have followed semantic version rules and not just bump a patch
Yeah, sorry about that!
The changes were documented and announced, but we should pay attention to the version numbers as well.
I created a PR: #142
this fixes the compile errors, but as I don't have a smartknob I can't test it out...