scline / docker-cacti

Cacti version 1+ under Docker

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Directories backup and backups mixed up

shortbloke opened this issue · comments

The backup script copies the resultant backup .tar.gz file to /backup however readme indicates it should be /backups
The docker-compose files also map /backups which then doesn't work as the backups are created within the container not in the mapped volume.

I'd submit changes, but I'm not sure if you'd prefer backup or backups to be used. It does contain multiple so the plural would make more sense. This would need the backup.sh to be updated and the readme.

I've created a suggested PR, in case that helps.

Closing since you created a PR that was merged, thank you!