CSV wrong column
thaneye opened this issue · comments
When executing Invoke-HardeningKitty -Mode Audit -Log -Report the generated csv as severity column contains "passed" along with medium and low. Typo?
No, not a typo. HardeningKitty uses passed as severity if a setting/check is correct/successful. We had this discussion in issue #19, and I added the row SeverityFinding to the CSV report (0x6d69636b/windows_hardening@9166ed8).
My recommendation would be to keep only one column related to "severity" (low, medium, high, critical) and the "test result". Otherwise it causes confusion and can lead to misunderstanding.
I see your point, however my requirements are to have a "positive" result aka "passed" and the HardeningKitty score (https://github.com/scipag/HardeningKitty#hardeningkitty-score) is based on passed as well. The log is a CSV and everybody is free to remove and/or rename the columns in it
You have passed already in test result column. If you filter on severity == passed it's the same as you would do with TestReult == failed.
However, I agree with your comment that everyone can change the csv.