not consider numDecimals = 0

Question

leohgbs opened this issue 3 years ago · comments

Subir · Answer 1 · Thu Mar 11 2021 19:58:00 GMT+0800 (China Standard Time)

@leohgbs Do you see an error when you set numDecimals to 0? Feel free to play around with the demo.

leohgbs · Answer 2 · Thu Mar 11 2021 21:31:49 GMT+0800 (China Standard Time)

roundHalfEven(255.552,0)
demo: 255
answer: 256

my solution

 if (numDecimals === 0) {
        return roundHalfEven(value/10, 1)*10
 }

Subir · Answer 3 · Thu Mar 11 2021 21:44:55 GMT+0800 (China Standard Time)

roundHalfEven(255.552,0)
demo: 255
answer: 256

my solution

 if (numDecimals === 0) {
        return roundHalfEven(value/10, 1)*10
 }

@leohgbs Thanks for catching that! Love your fix! Do you wanna send a PR?

Subir · Answer 4 · Fri Mar 12 2021 18:43:24 GMT+0800 (China Standard Time)

Fixed in v1.2.1