Giters

schnorr / starvz

R-based visualization techniques for the StarPU runtime

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Improve the phase1 script

schnorr opened this issue · comments

commented

Here are some suggestions to improve the phase1-workflow.sh.

  1. Application-identifying string, one of parameters, should be obligatory
  2. Assume all commands are in the PATH
  3. Check if all necessary commands are in the PATH in first place
commented

Comments:

  1. It should not be obligatory, imagine all-new programs..., It's not necessary to specify an application to StarVZ to work, its only cosmetics about colors. Also, StarVZ can identify application tasks because StarPU tasks are constant and strong defined. Also, maybe colors should be an option and not strong coded in R_package/R/phase2_applications.R.
  2. We already assume that no? Maybe

    starvz/src/phase1-workflow.sh

    Line 3 in b9c5f53

    DIR=$(pwd)/$(dirname $0)
    should be reconsidered.
  3. Partially done (starpu_fxt_tool and pj_dump) in 7c18bfa.
commented
  1. Partially(?) done (rec2csv) in a7f6be7.