sccn / xdf

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Missing Mex files in version 1.13

rstdm opened this issue · comments

Hello,
I put some work in making the Python implementation work faster (see this pull request) and last week some colleagues of mine who are using Matlab asked me weather I could do something similar with the Matlab version.
I had a quick glance on the source code and found those few lines of code:

LIBVERSION = '1.13';
[…]
if ~have_mex
	 mex_url = ['https://github.com/sccn/xdf/releases/download/v',...
       		 LIBVERSION, '/', fname];
	websave(fullfile(this_path, fname), mex_url);

So obviously this code tries to download the correct binary from the release section of GitHub using it’s version number 1.13. But the latest release on that page is version 1.12 which causes the server to respond with a 404 error code.
Because the source code of load_xdf_innerloop.c hasn’t changed since version 1.12 it should be sufficient if you upload the same files as a new release for version 1.13.

Disclaimer: I’m no Matlab user and don’t have access to a Matlab installation. Therefore all I wrote above are theoretical assumptions.

I can confirm that this problem occurs on MATLAB exactly as you described.

+1
But, you can compile for yourself
mex load_xdf_innerloop.c