CMake install broken for static builds
chausner opened this issue · comments
chausner commented
When setting LSL_BUILD_STATIC=ON
, the CMake install command fails with:
CMake Error: install(EXPORT "LSLTargets" ...) includes target "lsl" which requires target "lslobj" that is not in any export set.
CMake Error: install(EXPORT "LSLTargets" ...) includes target "lsl" which requires target "lslboost" that is not in any export set.
CMake Error in CMakeLists.txt:
export called with target "lsl" which requires target "lslobj" that is not
in any export set.
CMake Error in CMakeLists.txt:
export called with target "lsl" which requires target "lslboost" that is
not in any export set.
Seems commit 730e130 broke it.
Chadwick Boulay commented
I don't have time to look into this at the moment. Maybe @tstenner will tomorrow. Either way, we need a little more info.
What platform?
What version of cmake?
chausner commented
- Windows x64, MSVC 19.29.30133.0
- CMake 3.21.1
- CMake options
- BUILD_SHARED_LIBS=OFF
- LSL_BUILD_STATIC=ON
- LSL_BUNDLED_PUGIXML=OFF
- lslgitrevision=v1.15.2
- lslgitbranch=master
Tristan Stenner @PPI commented
I have identified the problem but it might take a few days to verify that my solution doesn't break anything else. I'll push a PR this or the next evening.