Clean up html_attributes

Question

Clean up html_attributes

noahgibbs opened this issue 8 months ago · comments

We no longer use html_attributes on slots or Para, and it never worked well (setting attributes, not styles, but we used it for styles.)

We should get rid of the remainders of it in Lacci.

Not 100% sure about Span. Can that go too? [Edit: gonna ignore it for now in Span. Span needs a general cleanup along with TextDrawable in general. It can wait for that.]

Noah Gibbs · Answer 1 · Mon Dec 11 2023 21:05:12 GMT+0800 (China Standard Time)

Ooh, I'm badly wrong here. We no longer pass html_attributes from Lacci as a Shoes-Style, but we 100% use them in Calzini because Scarpe-Webview generates them to do things like hover events. So yeah, should not remove them from Slot. We could use a test to make sure this keeps working, though.

Noah Gibbs · Answer 2 · Mon Dec 11 2023 21:05:46 GMT+0800 (China Standard Time)

I'm right that using them from Lacci was bad. I just didn't realise we were still using them for e.g. hover and click events.

Noah Gibbs · Answer 3 · Tue Dec 12 2023 08:09:42 GMT+0800 (China Standard Time)

Okay, I think this was a bad idea. Closing.