scarpe-team / scarpe

Scarpe - shoes but running on webview

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Lacci Shoes-Spec Interface

noahgibbs opened this issue · comments

We'd like test code -- including [https://github.com/scarpe-team/shoes-spec/wiki/DSLDesignNotes.md](several kinds of code that would be reasonable to have in prod too) -- to be standard across all display libraries.

Right now, one of the ugliest bits in Lacci can be found by searching for SHOES_SPEC_TEST -- it's using a scarpe-component, which is actually a no-no, and Minitest (also not a declared dependency) and doing wacky loader stuff, because you kind of have to have something like that in Lacci. But right now, ew, it's one of my worse hacks. Needs to change.

So instead, Lacci should include something like the scarpe-component file loader (s'okay, all display services have to use Lacci so it won't change their dependencies) and a test object to hand off the test code to. The the individual display service can implement all of it, including the Minitest-like asserts if it wants, without any extra mandatory dependencies. I like the Minitest import/export but I don't want to require the Minitest import/export for all display services.

Fixed by #435.