Decommission oldest test system
noahgibbs opened this issue · comments
We have two basically usable test systems (TEST_CONTROL, CatsCradle) with another on the way (ShoesSpec). It's time to get rid of the oldest and least convenient test system, which I'm calling TEST_CONTROL here, but also goes by similar names like ControlInterfaceTest.
It's used in test_control_interface.rb, test_web_wrangler.rb and test_slots.rb. You can identify it in a run_test_scarpe_code call because it uses the keyword "test_code:" instead of "app_test_code:". It uses the SCARPE_TEST_CONTROL environment variable to load from inside Scarpe after startup.
The tests for it should be reasonable to rewrite in CatsCradle, but may need some additional helper methods written (do we have an easy way to wait for init vs heartbeat? don't remember.)
But three test systems is too many, and TEST_CONTROL doesn't have much going for it at this point. It's worse in basically every way.
Incidentally: one reason not to decommission both older test systems is that ShoesSpec intends to be a multi-display-service test suite. While some cleanups are in order, we do want to have more specific testing for Scarpe-Webview that knows how to reach down and check generated HTML. You can't do that in a test suite that's designed to allow a non-HTML-based display service.