scandipwa / scandipwa

Next-generation front-end for Magento 2

Home Page:https://scandipwa.com/?utm_source=github&utm_medium=readme&utm_campaign=general

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Magento Patch ACSD-50260_2.4.5-p1_v2.patch breaks the catalog graphql

robertdeboer opened this issue · comments

Steps to reproduce:
This is when ScandiPWA is setup in storefont mode and built as a Magento theme and included in the Magento codebase when using ScandiPWA in a Magento Commerce Cloud application - docs here

  1. Update ece-patches to the latest version
  2. Apply patch ACSD-50260-V2
  3. Run ./bin/magento setup:di:compile

Actual result
The setup process will fail because the file \Magento\CatalogGraphQl\Model\Resolver\Products\DataProvider\ProductSearch\ProductCollectionSearchCriteriaBuilder that is referenced in the ScandiPWA Catalog GraphQL package has been removed by this Magento patch. The command will fail and you will get an error that that file does not exists.

Expected result
The ./bin/magento setup:di:compile should succeed

Testing details
Screenshot/Screencast

Warning: include(/app/vendor/composer/../magento/module-catalog-graph-ql/Model/Resolver/Products/DataProvider/ProductSearch/ProductCollectionSearchCriteriaBuilder.php): Failed to open stream: No such file or directory in /app/vendor/composer/ClassLoader.php   

Versions

  • ScandiPWA install version: Magento Commerce Cloud
  • ScandiPWA: 6.2.2
  • ScandiPWA/Catalog Graphql: 3.3.4
  • Magento: 2.4.6-p2
  • Magento Patch: ACSD-50260-V2

Additional context
I confirmed this by removing the vendor folder, removing the specific patch file from the list of patch files to apply, and then re-installing the vendor folder via composer install. The file was there and di:compile succeed.