scaleway / terraform-provider-scaleway

Terraform Scaleway provider

Home Page:https://www.terraform.io/docs/providers/scaleway/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

cockpit: migrate to v1 API

Codelax opened this issue · comments

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

To fix this issue, there should not be any call to cockpit/v1beta1.

New or Affected Resource(s)

  • scaleway_cockpit
    Deprecate old url attributes. Some should be fetched from scaleway_cockpit_source. grafana_url should probably be kept and fetched using the new API.
    An issue is the missing URLs in the new v1 API. They probably need to be hardcoded in terraform provider to avoid breaking those attributes (alertmanager_url, logs_url, metrics_url, traces_url)
    Should plan still be configured with this resource ? Or should we create a new resource dedicated to plan selection.
    Instead of only one call to get a cockpit, this will probably need to call GetGrafana and GetCurrentPlan.

  • data scaleway_cockpit
    Deprecate this datasource, most of its content should be contained in scaleway_cockpit_source.
    Considering the new lifecycle of a cockpit, this datasource could be replaced by the resource.

  • data scaleway_cockpit_plan
    Should this resource be deprecated ? plan_id no longer is a UUID, it uses its name as an ID (free, premium).

      const (
            PlanNameUnknownName = PlanName("unknown_name")
            PlanNameFree        = PlanName("free")
            PlanNamePremium     = PlanName("premium")
            PlanNameCustom      = PlanName("custom")
      )