scaffold-eth / scaffold-eth-typescript-challenges

All of our typescript challenges ported over from the javascript world

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Test for challenge-1-decentralized-staking does not exist

pontus-dev opened this issue · comments

In the vanilla JavaScript version of this challenge there is a file scaffold-eth-challenges/packages/hardhat/test/challenge_1.js. This file is missing in this TypeScript version of the challenge. Instead, there is only a sample test file scaffold-eth-typescript-challenges/packages/hardhat-ts/test/sample_test.ts which does not work due to chai not being installed as a package. It also does not test the challenge code.

In other words:
We need a version of challenge_1.js in this TypeScript version of the challenge. Preferably made into a TypeScript version.

Added this pull request to fix the issue:
#26