Update r.js dependency

Question

Update r.js dependency

zoltan-o opened this issue 10 years ago · comments

Zoltan Orban commented 10 years ago

I was wondering if it would be possible to update the r.js dependency to the latest version (2.1.15)?

Christopher Hunt · Answer 1 · Mon Sep 15 2014 19:24:30 GMT+0800 (China Standard Time)

Sure thing - care to raise a PR?

Zoltan Orban · Answer 2 · Mon Sep 15 2014 23:54:42 GMT+0800 (China Standard Time)

I don't mind raising a PR for the plugin, however I realised that it depends on a modified version of r.js. So I'm not sure if it's necessary to keep keep those changes in the webjar or is it okay if I use the original version of r.js in the new webjar.

Christopher Hunt · Answer 3 · Tue Sep 16 2014 07:28:17 GMT+0800 (China Standard Time)

The modification we did was to include a PR that we had on r.js, so updating the WebJar should now be fine. The PR was merged several months ago: requirejs/r.js#630