PingESP utility issue

Question

PingESP utility issue

Pronoe opened this issue 3 years ago · comments

Hello,
Thank you for your bootstrapper library.
I am using it to build my project of pool filtering pump management based on an ESP32.
I use also some pieces of code from your Smartostat.
I found an issue with PingESP utility because it does not seem to be ESP32 ready.
After including ESP32 definition, the compiler goes on but I still have an issue with the "extern "C" {#include <ping.h>}" declaration.
As I understand, this call for a pre-compiled ping C code.
Thank you for your help.
Patrick

Patrick SOUTY · Answer 1 · Fri Dec 24 2021 00:27:52 GMT+0800 (China Standard Time)

Hello,
I have solved the issue by installing the library ESP32Ping from https://github.com/marian-craciunescu/ESP32Ping and including the corresponding header in PingESP.h.
Its now compiling but the code is too big for the target (1.5 Mo for 1.3 Mo max) despite the operational code is limited to basic functions up to now.

Davide Perini · Answer 2 · Fri Dec 31 2021 06:52:00 GMT+0800 (China Standard Time)

Hi,
thank you for opening the issue Pronoe.

ESP8266 have built in functions to ping other devices while ESP32 don't have this features builtin.
That utility in particular works for ESP8266 only, if you want to use it on ESP32 you need an external lib.

There is no other way on ESP32 unfortunantly.
Feel free to reopen the issue if you need it :)

Patrick SOUTY · Answer 3 · Fri Dec 31 2021 20:28:55 GMT+0800 (China Standard Time)

Hi Davide, Thank you for your reply. I did use an external library as mentioned in the issue. I suggest however that you modify the PingESP.h file as proposed in the attached file. Meanwhile I have learnt that the “external C” directive was to link embedded functions of the micro controller. Regards Patrick De : Davide Perini ***@***.*** Envoyé : jeudi 30 décembre 2021 23:52 À : sblantipodi/arduino_bootstrapper Cc : Patrick SOUTY; Author Objet : Re: [sblantipodi/arduino_bootstrapper] PingESP utility issue (Issue #7) Hi, thank you for opening the issue Pronoe. ESP8266 have built in functions to ping other devices while ESP32 don't have this features builtin. That utility in particular works for ESP8266 only, if you want to use it on ESP32 you need an external lib. There is no other way on ESP32 unfortunantly. Feel free to reopen the issue if you need it :) — Reply to this email directly, view it on GitHub <#7 (comment)> , or unsubscribe <https://github.com/notifications/unsubscribe-auth/ASSUATV2LXA37TXM2ARX373UTTPBVANCNFSM5KU6PSFQ> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub> . You are receiving this because you authored the thread. <https://github.com/notifications/beacon/ASSUATWTA3D7DK4XPAZZJUTUTTPBVA5CNFSM5KU6PSF2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOHPF3BCQ.gif> Message ID: ***@***.***>

Patrick SOUTY · Answer 4 · Wed Mar 09 2022 04:07:01 GMT+0800 (China Standard Time)

After migration of my application to Bootstrapper 1.12.6 release, I have encountered some issues with PingESP because I had merged some modifications that I made locally for the ESP32 and your last modifications for the ESP8266. As I had also installed ESP8266 library for checking, I think the compiler might have merged some specific code for the ESP8266 and code for the ESP32.
Since then, I got in trouble with the WiFi link and my gateway was putting the link down for all the connected device.
It seems that I have finally solve this issue by adding a PingClass pingESP declaration in my own header file and keeping

#elif defined(ESP32) 
    #include <WiFi.h>
    #include <ESP32Ping.h>
    #include <ping.h>

in the PingESP.h header file.
I will propose later on a pull request for this file and to the README.md file to provide additional guidelines for ESP32 users.

Davide Perini · Answer 5 · Wed Mar 09 2022 23:51:57 GMT+0800 (China Standard Time)

thank you!!! I'll reopen it until your pull request...

github-actions · Answer 6 · Sat Apr 09 2022 08:30:31 GMT+0800 (China Standard Time)

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days

github-actions · Answer 7 · Wed May 11 2022 08:35:49 GMT+0800 (China Standard Time)

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days