sblantipodi / arduino_bootstrapper

Utility classes for bootstrapping Arduino projects with Wifi management, OTA upload management, memory management, MQTT and queue management. (ESP8266/ESP32 ready)

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Superfluous display reference

Reneg973 opened this issue · comments

Hi there,
nice project. But could you please remove the hardcoded reference to the display?

  • LED_BUILTIN: undeclared identifier used in nonblokingBlink

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days

Hi, du you think it will be possible to do this or do you prefer that I clone your repo and do it on my own?

Hi, sorry for the late reply, I'm very busy this days.
What do you want to remove exactly? in what file?

if you think that there is something that can be useful to everyone, you can open a pull request and I can merge it into the main branch. thanks!

Well first I have a system without a LED_BUILTIN. Second I don't have that display you are using with the graphics library. This output is not required to work with your library. So it should be optional.
What do you think? I am also a little bit busy. Would like to use this bootstrapper with my esp-01s.
Ok will try to make a PR

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days