breaking change for sasjsBuildFolder and sasjsResultsFolder
allanbowe opened this issue · comments
The sasjsbuild folder is used to prepare content ready for deployment, eg with the sasjs compile, sasjs build, sasjs web and sasjs fs sync commands.
The sasjsresults folder is used to store the output from a SAS execution, eg logs, test results, etc.
These folders are typically .gitignore'd however it is also important in some contexts to enable them to be written to a completely different (non-project) location.
Currently we have three attributes:
- https://cli.sasjs.io/sasjsconfig.html#buildOutputFolder
- https://cli.sasjs.io/sasjsconfig.html#buildConfig_buildOutputFolder
- https://cli.sasjs.io/sasjsconfig.html#buildConfig_buildResultsFolder
These should be reduced to just TWO, both of which should be in the root of the config (or root of the target), and also renamed to be more intuitive, eg as follows:
sasjsBuildFolder- default "sasjsbuild"sasjsResultsFolder- default "sasjsresults"
This can be a breaking change. There should be tests at both root and target level (if the setting is in both, the target overrules). It should also be tested for global (user) level configs.
This change will impact almost every command.
(previous comment about sasjstmp removed, we can do this at a future date)
🎉 This issue has been resolved in version 4.0.0 🎉
The release is available on:
Your semantic-release bot 📦🚀