Align 'legacy' version with phpunit supported versions?

Question

Align 'legacy' version with phpunit supported versions?

zbateson opened this issue 4 years ago · comments

phpunit 4.8.35 supports php as old as 5.3.3, could the legacy version be extended to that maybe?

In my case, I'm trying to align zbateson/mail-mime-parser with supported redhat releases, so I only really 'want' 5.4, but I guess others may have other needs.

Also I didn't notice anything specific in the code that's not 5.3-compatible, it looks to me like it's just the version constraint in composer.json.

Alexey Kopytko · Answer 1 · Thu Dec 10 2020 20:14:22 GMT+0800 (China Standard Time)

Let me see if I can do that.

Alexey Kopytko · Answer 2 · Thu Dec 10 2020 20:25:46 GMT+0800 (China Standard Time)

OK, should be in a tagged release. Please let me know if something is off.

Zaahid Bateson · Answer 3 · Fri Dec 11 2020 04:09:48 GMT+0800 (China Standard Time)

Works well, thank you!

Alexey Kopytko · Answer 4 · Fri Dec 11 2020 15:44:59 GMT+0800 (China Standard Time)

You should now be able to use doSetUp() and doTearDown() and so on in addition to previously used legacySetUp(). This is done to make code portable with SetUpTearDownTrait from PHPUnit-Bridge, but more so because PHP-CS-Fixer will sort these methods the same way it sorts setUp() and tearDown().