samuel / go-thrift

A native Thrift package for Go

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Flag variables should be passed to GoGenerator explicitly so that it is easy to call into go-thrift programmatically

colonelpanic8 opened this issue · comments

IMO, the only place that it is appropriate to use flag variables is in a main function. From that point onward they should be passed to the objects as configuration.

Is there any reason that the flag variables flagGoImportPrefix is not set in main and passed to the generator?