samuel / go-thrift

A native Thrift package for Go

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

strconv package, imported but not used

skoowoo opened this issue · comments

generate the code from a idl file(hbase thrift idl: http://wiki.apache.org/hadoop/Hbase/ThriftApi), there is a error, imported and not used: "strconv". Then I remove the "strconv" package, but not work well.

Fixed. strconv is used whne there's enums, but it seems hbase.thrift doesn't have any. It now is only imported when needed.

What are issues are you seeing other than the strconv?

Btw, you may want to try the -go.pointers=true flag if you need more strictness in what fields are sent.