samuel / go-thrift

A native Thrift package for Go

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Parser doesn't return useful position information on error

cespare opened this issue · comments

Right now the error shown to the user when you try to generate from an invalid thrift file only says the offset (not the filename, line, or column).

I've fixed this issue on my branches of go-thrift and go-parser. I don't have time right this minute to formulate them into a proper pull request, and I'm not sure you'd want to do it this way anyway (it requires changes to both of the repos together).

You can see what I did here:

ooyala/go-parser@9a7e0d6
ooyala@997808d