samrocketman / gitlab-mirrors

A set of scripts adding the ability of managing remote mirrors to GitLab.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

update requirements doc to use git 1.8.4

logicminds opened this issue · comments

The requirements say git 1.6.5 but I have git 1.7.1 on my system and I am getting errors with the update mirrors functionality. The error is that whenever prune is called only newer versions of git have this.

I don't know which version but I assume > 1.8.4. I have tested on 2.4.8 and it seems to work.

Seems git prune was first introduced in 2006. After investigation git prune was available in git 1.4.2. I doubt the root of the issue is around git prune not being available. Can you perhaps elaborate on the error you see? Running bash -xe update_mirror.sh mymirror will give more verbose output and quit when an error is encountered.

Here is the error that is performed when doing an update.

-bash-4.1$ more /home/gitmirror/gitlab-mirrors/cron.log
error: unknown option `prune'
usage: git push [<options>] [<repository> [<refspec>...]]

    -v, --verbose         be more verbose
    -q, --quiet           be more quiet
    --repo <repository>   repository
    --all                 push all refs
    --mirror              mirror all refs
    --delete              delete refs
    --tags                push tags (can't be used with --all or --mirror)
    -n, --dry-run         dry run
    --porcelain           machine-readable output
    -f, --force           force updates
    --thin                use thin pack
    --receive-pack <receive-pack>
                          receive pack program
    --exec <receive-pack>
                          receive pack program
    -u, --set-upstream    set upstream for git pull/status
    --progress            force progress reporting

error: unknown option `prune'



Ah, I get it. git push --prune is the option and that wasn't introduced until git v1.8.0. Agreed, the documentation should be updated.

For anybody seeing this error and cannot update to a newer version of git you can disable the prune feature in the gitlab-mirrors config file.

Just released v0.5.2 which is certified with GitLab 8.1.4. master reflects the latest stable release.