sampotts / plyr

A simple HTML5, YouTube and Vimeo player

Home Page:https://plyr.io

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Wrong condition that won't be satisfied

qugh opened this issue · comments

commented

https://github.com/sampotts/plyr/blob/master/src/js/fullscreen.js#L280

https://github.com/sampotts/plyr/blob/master/src/js/fullscreen.js#L259

You check the !Boolean(value), and then the string for emptiness. This condition should not work.

It's a valid point; the else if condition is negated by the condition above it.

commented

It's a valid point; the else if condition is negated by the condition above it.

ye. my mistake. its closed