Wrong condition that won't be satisfied
qugh opened this issue · comments
qugh commented
https://github.com/sampotts/plyr/blob/master/src/js/fullscreen.js#L280
https://github.com/sampotts/plyr/blob/master/src/js/fullscreen.js#L259
You check the !Boolean(value), and then the string for emptiness. This condition should not work.
Sam Potts commented
It's a valid point; the else if condition is negated by the condition above it.
qugh commented
It's a valid point; the else if condition is negated by the condition above it.
ye. my mistake. its closed